Repository navigation
refactor: share legacy WHERE parsing across query builders (simplify A8) - #7720
Open
mikemcdougall wants to merge 3 commits into
Open
mikemcdougall wants to merge 3 commits into
mikemcdougall wants to merge 3 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment
Founder simplification plan A8:
simplify-A8-where, fromhandoffs/rc2-lanes/takeover/SIMPLIFY-REVIEW-2026-11-13.md. One helper family per PR.Summary
Eight query builders duplicated WHERE parsing. Share the parser in Core while preserving each provider's accepted syntax, identifier mapping, numeric/text policy, SQL operators and parameter order, including parameters accumulated before a later parse failure. Four grammar profiles retain the existing provider differences.
Testing
Build-host provider suites passed: PostgreSQL165, MySQL83, SQL Server63, Oracle55, Redshift57, Snowflake44, DuckDB58. Core legacy parser tests16 and PostgreSQL WHERE/feature/storage tests243 also passed.
FeatureQueryBuilderWhereClauseTests,FeatureQueryBuilderFieldNameValidationTests, and each provider's FeatureQueryBuilderTests check unchanged generated SQL/parameters. Final build-hostpre-prstage 0 passed at eff4afe. Independent source-head review approved; subsequent change only refreshes canonical shipping notices.Parser options are explicit grammar/value enums; existing provider parameters and SQL behavior remain unchanged.
Gate Impact
PR build, tests and governance remain required.
Docs or Contract Impact
No HTTP, protocol, database or control-plane SDK contract changes.
Release/Deploy Impact
Standard rc.2 merge-and-release flow; no migration, infrastructure or settings changes.
Breaking Changes
None in supported service behavior.